Message79211
Comment about issue3826_gps05.diff:
- I don't like "magical" attributes (sometimes it does exist,
sometimes not) even if it's a protected attribute (_sock) => use
self._sock=None?
- fileno() returns a fixed value whereas the socket.fileno()
returns -1 when the socket is closed => returns -1 or raise an error
if the socket is closed?
- I'm not sure that your test is really working: read a closed socket
may raise an error because of the test on self._closed, not because
the low level socket is closed => use fileno() to check if the socket
is closed or not |
|
Date |
User |
Action |
Args |
2009-01-05 23:25:15 | vstinner | set | recipients:
+ vstinner, gvanrossum, loewis, jhylton, gregory.p.smith, amaury.forgeotdarc, ggenellina, zanella, romkyns |
2009-01-05 23:25:15 | vstinner | set | messageid: <1231197915.06.0.0497669744721.issue3826@psf.upfronthosting.co.za> |
2009-01-05 23:25:14 | vstinner | link | issue3826 messages |
2009-01-05 23:25:14 | vstinner | create | |
|