Message78653
You may want to check out issue1408710 in which a similar patch was
provided, but failed to deliver the desired results.
I didn't get the advertised ~15% speed-up, but only 4% on my Intel Core2
laptop and 8% on my AMD Athlon64 X2 desktop. I attached the benchmark
results.
The patch looks pretty clean. Here is a few things that caught my
attention while reading your patch.
First, you should rename opcode_targets.c to opcode_targets.h. This will
make it explicit that the file is not compiled, but just included.
Also, the macro USE_THREADED_CODE should be renamed to something else;
the word "thread" is too tightly associated with multi-threading.
Furthermore, threaded code simply refers to code consisting only of
function calls. Maybe, USE_COMPUTED_GOTO or USE_DIRECT_DISPATCH would be
better.
Finally, why do you disable your patch when DYNAMIC_EXECUTION_PROFILE or
LLTRACE is enabled? I tested your patch with both enabled and I didn't
see any test failures.
By the way, SUNCC also supports GCC's syntax for labels as values
(http://docs.sun.com/app/docs/doc/819-5265/bjabt?l=en&a=view). |
|
Date |
User |
Action |
Args |
2008-12-31 21:21:03 | alexandre.vassalotti | set | recipients:
+ alexandre.vassalotti, lemburg, skip.montanaro, arigo, pitrou, christian.heimes |
2008-12-31 21:21:02 | alexandre.vassalotti | set | messageid: <1230758462.37.0.48659077371.issue4753@psf.upfronthosting.co.za> |
2008-12-31 21:21:01 | alexandre.vassalotti | link | issue4753 messages |
2008-12-31 21:21:00 | alexandre.vassalotti | create | |
|