This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author alexandre.vassalotti
Recipients alexandre.vassalotti, amaury.forgeotdarc, ocean-city
Date 2008-10-31.01:04:46
SpamBayes Score 6.244505e-12
Marked as misclassified No
Message-id <1225415090.45.0.461002312984.issue4176@psf.upfronthosting.co.za>
In-reply-to
Content
Thank you, Amaury, for fixing this. However, you forgot to also patch
the Python implementation of pickle, which makes the following test fail:

======================================================================
FAIL: test_reduce_bad_iterator (__main__.PyPicklerTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/alex/src/python.org/py3k/Lib/test/pickletester.py", line
892, in test_reduce_bad_iterator
    self.assertRaises(pickle.PickleError, self.dumps, C(), proto)
AssertionError: PickleError not raised by dumps


Also, I am not sure if moving the type and length check of the reduce
value into save_reduce() was a good idea. In pickle.py, the check must 
be done before calling save_reduce(), since the method is called with
the star-syntax "self.save_reduce(obj=obj, *rv)". In _pickle, there's no
such requirement; however I don't like the idea of adding needless
differences.
History
Date User Action Args
2008-10-31 01:04:50alexandre.vassalottisetrecipients: + alexandre.vassalotti, amaury.forgeotdarc, ocean-city
2008-10-31 01:04:50alexandre.vassalottisetmessageid: <1225415090.45.0.461002312984.issue4176@psf.upfronthosting.co.za>
2008-10-31 01:04:49alexandre.vassalottilinkissue4176 messages
2008-10-31 01:04:47alexandre.vassalotticreate