This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author christian.heimes
Recipients amaury.forgeotdarc, christian.heimes
Date 2008-10-30.01:18:51
SpamBayes Score 0.03461082
Marked as misclassified No
Message-id <1225329532.83.0.711614602841.issue4237@psf.upfronthosting.co.za>
In-reply-to
Content
I propose to move self->closefd closer to the top of the function:

Index: Modules/_fileio.c
===================================================================
--- Modules/_fileio.c   (Revision 67040)
+++ Modules/_fileio.c   (Arbeitskopie)
@@ -181,6 +181,7 @@

        self->readable = self->writable = 0;
        self->seekable = -1;
+       self->closefd = closefd;
        s = mode;
        while (*s) {
                switch (*s++) {
@@ -243,7 +244,6 @@

        if (fd >= 0) {
                self->fd = fd;
-               self->closefd = closefd;
        }
        else {
                self->closefd = 1;
History
Date User Action Args
2008-10-30 01:18:52christian.heimessetrecipients: + christian.heimes, amaury.forgeotdarc
2008-10-30 01:18:52christian.heimessetmessageid: <1225329532.83.0.711614602841.issue4237@psf.upfronthosting.co.za>
2008-10-30 01:18:52christian.heimeslinkissue4237 messages
2008-10-30 01:18:51christian.heimescreate