Message74082
r66677 introduces a reference leak in test_cprofile, as shown by
http://mail.python.org/pipermail/python-checkins/2008-September/074355.html
IMO, the code at the end of the function should not have been modified
this way. It is enough to do:
if (PyErr_Occurred()) {
PyErr_WriteUnraisable(pObj->externalTimer);
return 0;
}
it's the same "PyErr_WriteUnraisable" statement as 18 lines above, which
is valid because pObj->externalTimer is still a living python object
even if pObj is being cleared. |
|
Date |
User |
Action |
Args |
2008-09-30 16:01:01 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, brett.cannon, benjamin.peterson |
2008-09-30 16:01:00 | amaury.forgeotdarc | set | messageid: <1222790460.96.0.104534015771.issue4003@psf.upfronthosting.co.za> |
2008-09-30 16:01:00 | amaury.forgeotdarc | link | issue4003 messages |
2008-09-30 16:00:58 | amaury.forgeotdarc | create | |
|