Message72741
> This is my first excursion into cyclic garbage collector
> implementations, so please review carefully.
If you don't implement a tp_clear function, you should leave
a comment why not. I think it's ok, since the underlying
containers will get cleared, thus breaking the cycle.
> Also, I am not sure about
> tp_traverse for the deque type. Must the block member also be considered
> or is the deque member sufficient?
It is fine as-is. The iterator doesn't own the reference to the block
objects, and traversing the deque will also traverse all contained
objects.
> Finally, do you consider this a show stopper?
Not me. As-is, this bug doesn't cause crashes, and can be worked-around
in applications (by explicitly breaking the cycle). |
|
Date |
User |
Action |
Args |
2008-09-07 16:16:03 | loewis | set | recipients:
+ loewis, jcea, amaury.forgeotdarc, schuppenies |
2008-09-07 16:16:02 | loewis | link | issue3680 messages |
2008-09-07 16:16:02 | loewis | create | |
|