This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author loewis
Recipients amaury.forgeotdarc, jcea, loewis, schuppenies
Date 2008-09-07.16:16:02
SpamBayes Score 1.4757527e-08
Marked as misclassified No
Message-id <48C3FE40.1010109@v.loewis.de>
In-reply-to <1219697025.92.0.458237292903.issue3680@psf.upfronthosting.co.za>
Content
> This is my first excursion into cyclic garbage collector
> implementations, so please review carefully.

If you don't implement a tp_clear function, you should leave
a comment why not. I think it's ok, since the underlying
containers will get cleared, thus breaking the cycle.

> Also, I am not sure about
> tp_traverse for the deque type. Must the block member also be considered
> or is the deque member sufficient?

It is fine as-is. The iterator doesn't own the reference to the block
objects, and traversing the deque will also traverse all contained
objects.

> Finally, do you consider this a show stopper?

Not me. As-is, this bug doesn't cause crashes, and can be worked-around
in applications (by explicitly breaking the cycle).
History
Date User Action Args
2008-09-07 16:16:03loewissetrecipients: + loewis, jcea, amaury.forgeotdarc, schuppenies
2008-09-07 16:16:02loewislinkissue3680 messages
2008-09-07 16:16:02loewiscreate