This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients benjamin.peterson, georg.brandl, orivej, pitrou, pyscripter
Date 2008-08-06.10:16:28
SpamBayes Score 4.3787004e-06
Marked as misclassified No
Message-id <1218017790.31.0.805132189472.issue1685@psf.upfronthosting.co.za>
In-reply-to
Content
After a look at the patch and at linecache.py, some comments:
- 'rbU' is strange, the 'U' flag has no effect for binary files, so it
should just be 'rb' instead
- I'm surprised we don't have a test_linecache.py in Lib/test
- The following lines at the end of updatecache() deserve a cleanup:

    try:
        lines = [line if isinstance(line, str) else str(line, coding)
                 for line in lines]
    except:
        pass  # Hope for the best

- The very shallow "except Exception as msg" should also be restricted
to (IOError, OSError) IMHO.
History
Date User Action Args
2008-08-06 10:16:30pitrousetrecipients: + pitrou, georg.brandl, pyscripter, benjamin.peterson, orivej
2008-08-06 10:16:30pitrousetmessageid: <1218017790.31.0.805132189472.issue1685@psf.upfronthosting.co.za>
2008-08-06 10:16:29pitroulinkissue1685 messages
2008-08-06 10:16:28pitroucreate