Message70779
After a look at the patch and at linecache.py, some comments:
- 'rbU' is strange, the 'U' flag has no effect for binary files, so it
should just be 'rb' instead
- I'm surprised we don't have a test_linecache.py in Lib/test
- The following lines at the end of updatecache() deserve a cleanup:
try:
lines = [line if isinstance(line, str) else str(line, coding)
for line in lines]
except:
pass # Hope for the best
- The very shallow "except Exception as msg" should also be restricted
to (IOError, OSError) IMHO. |
|
Date |
User |
Action |
Args |
2008-08-06 10:16:30 | pitrou | set | recipients:
+ pitrou, georg.brandl, pyscripter, benjamin.peterson, orivej |
2008-08-06 10:16:30 | pitrou | set | messageid: <1218017790.31.0.805132189472.issue1685@psf.upfronthosting.co.za> |
2008-08-06 10:16:29 | pitrou | link | issue1685 messages |
2008-08-06 10:16:28 | pitrou | create | |
|