Message 69635 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	collinwinter
Recipients	collinwinter, nedds
Date	2008-07-14.01:11:21
SpamBayes Score	0.0035978332
Marked as misclassified	No
Message-id	<1215997883.05.0.218877333328.issue3218@psf.upfronthosting.co.za>
In-reply-to

Content
fix_imports.diff fails to apply cleanly against HEAD of fix_imports.py. Also, fix_imports2 now inherits from fix_imports, so it needs to be fixed as well. + yield """power< module_name=%r + trailer<'.' import_as_names< any > > any* > + """ % old_module Why are you using import_as_names here? That's meant to match a series of "NAME [as NAME]" in import statements, where this part of the pattern is meant to match usages of "urllib.foo()" in the code.

fix_imports.diff fails to apply cleanly against HEAD of fix_imports.py.
Also, fix_imports2 now inherits from fix_imports, so it needs to be
fixed as well.


+         yield """power< module_name=%r 
+                  trailer<'.' import_as_names< any > > any* >
+               """ % old_module

Why are you using import_as_names here? That's meant to match a series
of "NAME [as NAME]" in import statements, where this part of the pattern
is meant to match usages of "urllib.foo()" in the code.

History
Date	User	Action	Args
2008-07-14 01:11:23	collinwinter	set	spambayes_score: 0.00359783 -> 0.0035978332 recipients: + collinwinter, nedds
2008-07-14 01:11:23	collinwinter	set	spambayes_score: 0.00359783 -> 0.00359783 messageid: <1215997883.05.0.218877333328.issue3218@psf.upfronthosting.co.za>
2008-07-14 01:11:22	collinwinter	link	issue3218 messages
2008-07-14 01:11:21	collinwinter	create