Message 68914 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	oefe
Recipients	oefe
Date	2008-06-28.21:31:45
SpamBayes Score	0.37404844
Marked as misclassified	No
Message-id	<1214688707.09.0.872875806221.issue3230@psf.upfronthosting.co.za>
In-reply-to

Content
The first use of PySet_GET_SIZE in dict_fromkeys (file dictobject.c) is applied to a PyDictObject. These seem to work by chance, as the PyDictObject and PySetObject have very similar structure so that it does not matter if you cast a PyDictObject* to a PySetObject*. But if their structure ever diverges, this would cause unpredictable behaviour. Thus, this use of PySet_GET_SIZE should probably be replaced with a call of PyDict_Size. (There are two more calls to PySet_GET_SIZE resp. _PySet_NextEntry in the same function, but these are OK as they actually apply to a set.)

The first use of PySet_GET_SIZE in dict_fromkeys (file dictobject.c) is applied to a PyDictObject. These seem to work by chance, as the PyDictObject and PySetObject have very 
similar structure so that it does not matter if you cast a PyDictObject* to a PySetObject*. But if their structure ever diverges, this would cause unpredictable behaviour.

Thus, this use of PySet_GET_SIZE should probably be replaced with a call of PyDict_Size.

(There are two more calls to PySet_GET_SIZE resp. _PySet_NextEntry in the same function, 
but these are OK as they actually apply to a set.)

History
Date	User	Action	Args
2008-06-28 21:31:47	oefe	set	spambayes_score: 0.374048 -> 0.37404844 recipients: + oefe
2008-06-28 21:31:47	oefe	set	spambayes_score: 0.374048 -> 0.374048 messageid: <1214688707.09.0.872875806221.issue3230@psf.upfronthosting.co.za>
2008-06-28 21:31:45	oefe	link	issue3230 messages
2008-06-28 21:31:45	oefe	create