Message 68325 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rhettinger
Recipients	Indy, rhettinger
Date	2008-06-17.13:56:31
SpamBayes Score	0.0033536772
Marked as misclassified	No
Message-id	<1213710995.56.0.144631352952.issue3078@psf.upfronthosting.co.za>
In-reply-to

Content
Sorry, I don't see any value in this kind of patch. The line "contline = += line" is broken. The "+=" transformations and else-clause eliminations trivially re-arrange code without any real savings. The "while 1" to "while True" transformation should not be done in Py2.x because the latter is much slower ("while True" requires loading a global variable and a test; in contrast, "while 1" is optimized to an unconditional jump.

Sorry, I don't see any value in this kind of patch.

The line "contline = += line"  is broken. The "+=" transformations and 
else-clause eliminations trivially re-arrange code without any real 
savings.  The "while 1" to "while True" transformation should not be 
done in Py2.x because the latter is much slower ("while True" requires 
loading a global variable and a test; in contrast, "while 1" is 
optimized to an unconditional jump.

History
Date	User	Action	Args
2008-06-17 13:56:36	rhettinger	set	spambayes_score: 0.00335368 -> 0.0033536772 recipients: + rhettinger, Indy
2008-06-17 13:56:35	rhettinger	set	spambayes_score: 0.00335368 -> 0.00335368 messageid: <1213710995.56.0.144631352952.issue3078@psf.upfronthosting.co.za>
2008-06-17 13:56:34	rhettinger	link	issue3078 messages
2008-06-17 13:56:34	rhettinger	create