Message66311
This looks good. I would suggest that the unredirected_hdrs would use
the CaseInsensitiveDict too.
There is still the problem (from the test documentation) that accessing
.headers directly will only show a subset of headers i.e. it won't show
any headers from .unredirected_hdrs. Have you any suggestions as to how
they both can be accessed from the same interface?
The test documentation also says:
"Note the case normalization of header names here, to
.capitalize()-case. This should be preserved for
backwards-compatibility. (In the HTTP case, normalization to
.title()-case is done by urllib2 before sending headers to
httplib)."
It suggests that capitalize() should be kept for backwards
compatibility. I have tested and the headers actually sent to the
server are in title()-case even though they are stored in the Request
object as captitalize()-case.
This would initially suggest that the case-normalization should be
removed from the patch. However, as .headers would now be using a
case-insensitive dictionary, this would still ensure backwards compatibily. |
|
| Date |
User |
Action |
Args |
| 2008-05-06 12:21:47 | BitTorment | set | spambayes_score: 0.0285502 -> 0.0285502 recipients:
+ BitTorment, jjlee, orsenthil, frispete |
| 2008-05-06 12:21:46 | BitTorment | set | spambayes_score: 0.0285502 -> 0.0285502 messageid: <1210076506.46.0.590277446088.issue2275@psf.upfronthosting.co.za> |
| 2008-05-06 12:21:45 | BitTorment | link | issue2275 messages |
| 2008-05-06 12:21:43 | BitTorment | create | |
|