Message 66063 - Python tracker

Author	belopolsky
Recipients	belopolsky, benjamin.peterson, facundobatista, gvanrossum
Date	2008-05-02.03:43:59
SpamBayes Score	0.449978
Marked as misclassified	No
Message-id	<1209699843.5.0.327534410832.issue2735@psf.upfronthosting.co.za>
In-reply-to

Content
- With length precomputed in range_new, we can probably get rid of get_len_of_range. - There is no need to recompute length in range_iter. A nit: iterator object's size member is called "len", but the same member of the range object is called "length." I have no preference between the two names, but I think they should be the same. Off-topic: why optimized iterator uses long rather than ssize_t arithmetics? On x86-64, ssize_t is 64 and long is 32 bit.

- With length precomputed in range_new, we can probably get rid of 
get_len_of_range.

 - There is no need to recompute length in range_iter.

A nit: iterator object's size member is called "len", but the same 
member of the range object is called "length."  I have no preference 
between the two names, but I think they should be the same.

Off-topic: why optimized iterator uses long rather than ssize_t 
arithmetics?  On x86-64, ssize_t is 64 and long is 32 bit.

History
Date	User	Action	Args
2008-05-02 03:44:04	belopolsky	set	spambayes_score: 0.449978 -> 0.449978 recipients: + belopolsky, gvanrossum, facundobatista, benjamin.peterson
2008-05-02 03:44:03	belopolsky	set	spambayes_score: 0.449978 -> 0.449978 messageid: <1209699843.5.0.327534410832.issue2735@psf.upfronthosting.co.za>
2008-05-02 03:44:02	belopolsky	link	issue2735 messages
2008-05-02 03:44:00	belopolsky	create