Message 65524 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gvanrossum
Recipients	amaury.forgeotdarc, belopolsky, benjamin.peterson, georg.brandl, gvanrossum
Date	2008-04-15.18:01:24
SpamBayes Score	0.04142215
Marked as misclassified	No
Message-id	<1208282486.18.0.597705598528.issue2603@psf.upfronthosting.co.za>
In-reply-to

Content
Code review: Objects/rangeobject.c: line 259-260: AFAIK register is completely useless in this day and age; drop it. line 296 and further: Please move the \|\| and && operators to the end of the previous line. line 313 etc: This all fits on one line. Line 319-320: Ditto. Line 361: Please make the comment line up. Lib/test/test_builtin.py: I'd like to see another test indicating which of the following is true: range(0, 11, 2) == range(0, 10, 2) or range(0, 11, 2) != range(0, 10, 2) (since they produce the same sequence of values). Also, add a test for __hash__() of a range().

Code review:

Objects/rangeobject.c:

line 259-260:
AFAIK register is completely useless in this day and age; drop it.

line 296 and further:
Please move the || and && operators to the end of the previous line.

line 313 etc:
This all fits on one line.

Line 319-320:
Ditto.

Line 361:
Please make the comment line up.

Lib/test/test_builtin.py:
I'd like to see another test indicating which of the following is true:

range(0, 11, 2) == range(0, 10, 2)

or

range(0, 11, 2) != range(0, 10, 2)

(since they produce the same sequence of values).

Also, add a test for __hash__() of a range().

History
Date	User	Action	Args
2008-04-15 18:01:26	gvanrossum	set	spambayes_score: 0.0414222 -> 0.04142215 recipients: + gvanrossum, georg.brandl, amaury.forgeotdarc, belopolsky, benjamin.peterson
2008-04-15 18:01:26	gvanrossum	set	spambayes_score: 0.0414222 -> 0.0414222 messageid: <1208282486.18.0.597705598528.issue2603@psf.upfronthosting.co.za>
2008-04-15 18:01:25	gvanrossum	link	issue2603 messages
2008-04-15 18:01:24	gvanrossum	create