This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author belopolsky
Recipients belopolsky, flxkid, gvanrossum, jafo, mamrhein, vdupras
Date 2008-04-11.14:00:38
SpamBayes Score 0.045029473
Marked as misclassified No
Message-id <1207922440.19.0.651874342164.issue1738@psf.upfronthosting.co.za>
In-reply-to
Content
+1 on adding the match argument.  Can you comment on how one would 
implement the old behavior? I would guess match=lambda x,y: x in y, 
which is not that bad, but maybe that should be the default and those 
who need pattern matching should use match=fnmatch.

On the patch itself, please don't change default arguments from None to 
lists or function.  There is a subtle difference between the two forms. 
For example, in your code if someone overrides filecmp.fnmatch before 
calling dircmp, old fnmatch will still be used.  If you do match=None in  
finction declaration and match is None check in the function body, then 
the new overridden value will be used in the above scenario.
History
Date User Action Args
2008-04-11 14:00:40belopolskysetspambayes_score: 0.0450295 -> 0.045029473
recipients: + belopolsky, gvanrossum, jafo, mamrhein, flxkid, vdupras
2008-04-11 14:00:40belopolskysetspambayes_score: 0.0450295 -> 0.0450295
messageid: <1207922440.19.0.651874342164.issue1738@psf.upfronthosting.co.za>
2008-04-11 14:00:39belopolskylinkissue1738 messages
2008-04-11 14:00:38belopolskycreate