Message 64653 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	wolever
Recipients	collinwinter, dangyogi, loewis, wolever
Date	2008-03-28.20:59:45
SpamBayes Score	0.002387482
Marked as misclassified	No
Message-id	<66A881BA-FA70-4977-859C-F9962DBA6EEE@cs.toronto.edu>
In-reply-to	<1206736914.2.0.644708268708.issue2446@psf.upfronthosting.co.za>

Content
Ah, yes -- that may be the fault of the confusingly named 'check_both'. The "both" means "both when the module in question exists and when it does not". If you've got a better name, please change it! Take a look at the method and you'll see how it works. The problem is that testing this is a little tricky -- you've either got to give it files that you know exist, create files, or work some magic. I took the work some magic route, and replaced the "exists" method which fix_import imports from os (that way the tests can check the list of files which are being checked). See the test_files_checked method for that.

Ah, yes -- that may be the fault of the confusingly named  
'check_both'.  The "both" means "both when the module in question  
exists and when it does not".  If you've got a better name, please  
change it!
Take a look at the method and you'll see how it works.

The problem is that testing this is a little tricky -- you've either  
got to give it files that you know exist, create files, or work some  
magic.
I took the work some magic route, and replaced the "exists" method  
which fix_import imports from os (that way the tests can check the  
list of files which are being checked).
See the test_files_checked method for that.

History
Date	User	Action	Args
2008-03-28 20:59:46	wolever	set	spambayes_score: 0.00238748 -> 0.002387482 recipients: + wolever, loewis, collinwinter, dangyogi
2008-03-28 20:59:45	wolever	link	issue2446 messages
2008-03-28 20:59:45	wolever	create