This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients pitrou
Date 2008-03-24.12:09:33
SpamBayes Score 0.0035967045
Marked as misclassified No
Message-id <1206360580.92.0.370388118897.issue2472@psf.upfronthosting.co.za>
In-reply-to
Content
This is a rewrite of the block ordering code in the compiler package
(specifically, the flowgraph part). The previous code was littered with
self-admitted "hacks", "fixups" and "XXX" :-) They are all removed and
replaced with a clean ``order_blocks`` function which does the right
thing from the start.

The patch also replaces a wrong startBlock() with a nextBlock() in
compiler.pycodegen (startBlock can only be used when the previous block
does an unconditional transfer to another one, otherwise the two
adjacent blocks may not be emitted in order).

I've run test_compiler a couple of times, and tested execution of
several functions. They all run fine. Unless someone has specific
reasons to reject the patch, I'd recommend applying it even if not many
people use the compiler package :) I needed the fixes for my work on #2459.
History
Date User Action Args
2008-03-24 12:09:41pitrousetspambayes_score: 0.0035967 -> 0.0035967045
recipients: + pitrou
2008-03-24 12:09:41pitrousetspambayes_score: 0.0035967 -> 0.0035967
messageid: <1206360580.92.0.370388118897.issue2472@psf.upfronthosting.co.za>
2008-03-24 12:09:38pitroulinkissue2472 messages
2008-03-24 12:09:37pitroucreate