Message 63826 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	gvanrossum
Recipients	benjamin.peterson, gvanrossum
Date	2008-03-18.00:44:09
SpamBayes Score	0.03604142
Marked as misclassified	No
Message-id	<1205801050.74.0.577315916295.issue2374@psf.upfronthosting.co.za>
In-reply-to

Content
Let's not do this. This approach is not sufficiently backwards compatible; it will break any code that uses isinstance(x, file). Even though that's not forward compatible with 3.0, it works in 2.5 and before, so it should not break in 2.6. Together with my previous remark this means that we should just not mess with this. (PS: I don't understand what you say about distutils.text_file -- from your patch it looks like the only way it can issue this warning is if it actually calls the file() builtin...)

Let's not do this. This approach is not sufficiently backwards
compatible; it will break any code that uses isinstance(x, file).  Even
though that's not forward compatible with 3.0, it works in 2.5 and
before, so it should not break in 2.6.  Together with my previous remark
this means that we should just not mess with this.

(PS: I don't understand what you say about distutils.text_file -- from
your patch it looks like the only way it can issue this warning is if it
actually calls the file() builtin...)

History
Date	User	Action	Args
2008-03-18 00:44:10	gvanrossum	set	spambayes_score: 0.0360414 -> 0.03604142 recipients: + gvanrossum, benjamin.peterson
2008-03-18 00:44:10	gvanrossum	set	spambayes_score: 0.0360414 -> 0.0360414 messageid: <1205801050.74.0.577315916295.issue2374@psf.upfronthosting.co.za>
2008-03-18 00:44:10	gvanrossum	link	issue2374 messages
2008-03-18 00:44:09	gvanrossum	create