Message 63622 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	ceder
Recipients	ceder
Date	2008-03-17.08:00:04
SpamBayes Score	0.10971231
Marked as misclassified	No
Message-id	<1205740809.7.0.649649150956.issue2315@psf.upfronthosting.co.za>
In-reply-to

Content
If TimedRotatingFileHandler is instructed to roll over the log at midnight or on a certain weekday, it needs to consider when daylight savings time starts and ends. The current code just blindly adds self.interval to self.rolloverAt, totally ignoring that sometimes it should add 23 or 25 hours instead of 24 hours. (I suspect that the implementation would be simpler if you use the datetime module, rather than attempt to patch the existing code.)

If TimedRotatingFileHandler is instructed to roll over the log at
midnight or on a certain weekday, it needs to consider when daylight
savings time starts and ends. The current code just blindly adds
self.interval to self.rolloverAt, totally ignoring that sometimes it
should add 23 or 25 hours instead of 24 hours.

(I suspect that the implementation would be simpler if you use the
datetime module, rather than attempt to patch the existing code.)

History
Date	User	Action	Args
2008-03-17 08:00:10	ceder	set	spambayes_score: 0.109712 -> 0.10971231 recipients: + ceder
2008-03-17 08:00:09	ceder	set	spambayes_score: 0.109712 -> 0.109712 messageid: <1205740809.7.0.649649150956.issue2315@psf.upfronthosting.co.za>
2008-03-17 08:00:05	ceder	link	issue2315 messages
2008-03-17 08:00:04	ceder	create