Message 62603 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rhettinger
Recipients	rhettinger, zanella
Date	2008-02-20.22:06:25
SpamBayes Score	0.056518614
Marked as misclassified	No
Message-id	<1203545187.45.0.0770376719673.issue2149@psf.upfronthosting.co.za>
In-reply-to

Content
This is probably a matter of style. For the most part, library code avoids isinstance() checks and lets the errors surface downstream. If a check gets added, we should probably also check that the value is non-negative. The checks should not be backported because it could break Queue subclasses that rely on being able to pass in a non-int value (like None or like a dynamic object that allows the maxsize to be increased during the run). I'm unclear why this got classified as a security issue rather than just an RFE for Py2.6.

This is probably a matter of style.  For the most part, library code
avoids isinstance() checks and lets the errors surface downstream. 

If a check gets added, we should probably also check that the value is
non-negative.  The checks should not be backported because it could
break Queue subclasses that rely on being able to pass in a non-int
value (like None or like a dynamic object that allows the maxsize to be
increased during the run).

I'm unclear why this got classified as a security issue rather than just
an RFE for Py2.6.

History
Date	User	Action	Args
2008-02-20 22:06:27	rhettinger	set	spambayes_score: 0.0565186 -> 0.056518614 recipients: + rhettinger, zanella
2008-02-20 22:06:27	rhettinger	set	spambayes_score: 0.0565186 -> 0.0565186 messageid: <1203545187.45.0.0770376719673.issue2149@psf.upfronthosting.co.za>
2008-02-20 22:06:26	rhettinger	link	issue2149 messages
2008-02-20 22:06:25	rhettinger	create