➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author nnorwitz
Recipients Rhamphoryncus, arigo, brett.cannon, gvanrossum, jhylton, mwh, nnorwitz, zseil
Date 2008-01-24.07:12:08
SpamBayes Score 0.037235305
Marked as misclassified No
Message-id <ee2a432c0801232312v9690ac8o214ac72cb1191f48@mail.gmail.com>
In-reply-to <1201143442.37.0.111260340717.issue1303614@psf.upfronthosting.co.za>
Content 
I looked at Guido's latest deldict.diff patch--the one to
Objects/object.c only.  It seems good.  I can't convince myself either
way about the change to Objects/typeobject.c.  I can't think of a way
to cause a problem.  It seems safer to use Py_CLEAR in this case
though.

There are several other uses of _PyObject_GetDictPtr in
Objects/typeobject.c.  It was pretty much the same--I can't convince
myself either way.  Can Py_VISIT cause any Python code to execute that
might lead to a problem?  The other uses of _PyObject_GetDictPtr in
Objects/typeobject.c seemed safer.  Not a very useful review.
History
Date User Action Args
2008-01-24 07:12:12nnorwitzsetspambayes_score: 0.0372353 -> 0.037235305
recipients: + nnorwitz, mwh, gvanrossum, jhylton, brett.cannon, arigo, Rhamphoryncus, zseil
2008-01-24 07:12:10nnorwitzlinkissue1303614 messages
2008-01-24 07:12:09nnorwitzcreate