Message 61448 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	loewis
Recipients	christian.heimes, georg.brandl, lillo, loewis, pitrou
Date	2008-01-21.21:03:27
SpamBayes Score	0.28293198
Marked as misclassified	No
Message-id	<1200949409.91.0.793473697834.issue1720595@psf.upfronthosting.co.za>
In-reply-to

Content
I can't see anything wrong with the feature. Of course, the patch itself lacks changes to the test suite. Ideally, there would also be changes to the documentation, but as PyMemberDef seems to be undocumented currently, it's unfair to ask for documentation with this patch. If documentation was made, it should list for each T_ constant what the corresponding C type should be. I think the cast to long (in PyBool_FromLong) is redundant.

I can't see anything wrong with the feature. Of course, the patch itself
lacks changes to the test suite.

Ideally, there would also be changes to the documentation, but as
PyMemberDef seems to be undocumented currently, it's unfair to ask for
documentation with this patch. If documentation was made, it should list
for each T_ constant what the corresponding C type should be.

I think the cast to long (in PyBool_FromLong) is redundant.

History
Date	User	Action	Args
2008-01-21 21:03:30	loewis	set	spambayes_score: 0.282932 -> 0.28293198 recipients: + loewis, georg.brandl, pitrou, christian.heimes, lillo
2008-01-21 21:03:29	loewis	set	spambayes_score: 0.282932 -> 0.282932 messageid: <1200949409.91.0.793473697834.issue1720595@psf.upfronthosting.co.za>
2008-01-21 21:03:28	loewis	link	issue1720595 messages
2008-01-21 21:03:27	loewis	create