This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author alanmcintyre
Recipients alanmcintyre, bialix, gvanrossum
Date 2008-01-05.10:41:40
SpamBayes Score 0.0017607494
Marked as misclassified No
Message-id <1199529701.73.0.921935432784.issue1526@psf.upfronthosting.co.za>
In-reply-to
Content
The reported warning was being produced when writing the "end of central
directory record", in ZipFile.close().

Based on a little experiment with 70k test text files, the default
archiver in OS X appears to just use the number of files mod 64k in the
end of central directory record. I tweaked the ZipFile close() method to
do this, and the resulting ZIP file appears to work just fine, both with
the OS X archiver and with ZipFile (without ZIP64 enabled).  

There's a blurb in the ZIP format description about this sort of thing:
"If an archive is in ZIP64 format and the value in this field is 0xFFFF,
the size will be in the corresponding 8 byte zip64 end of central
directory field."  I don't know if that means "the right thing" is to
switch the archive to ZIP64 format if more than 64k files are added, though.

If I have time I'll go look at some other open source ZIP
implementations, but I won't swear I'll ever get around to it. :)
History
Date User Action Args
2008-01-05 10:41:42alanmcintyresetspambayes_score: 0.00176075 -> 0.0017607494
recipients: + alanmcintyre, gvanrossum, bialix
2008-01-05 10:41:41alanmcintyresetspambayes_score: 0.00176075 -> 0.00176075
messageid: <1199529701.73.0.921935432784.issue1526@psf.upfronthosting.co.za>
2008-01-05 10:41:41alanmcintyrelinkissue1526 messages
2008-01-05 10:41:40alanmcintyrecreate