Author draghuram
Recipients amaury.forgeotdarc, christian.heimes, draghuram, facundobatista, gvanrossum, ianare
Date 2007-12-04.21:10:49
SpamBayes Score 0.0185998
Marked as misclassified No
Message-id <1196802650.58.0.463037739964.issue1545@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments about shutil.diff:

1) This seems to be against 2.5. You would be better off submitting a
patch against trunk. In case of bug fixes, it will usually be back
ported. This particular change is not a bug fix though.

2) patches should be either context diff or preferably unified diffs. In
addition, a patch should be a forward diff (diff <original file>
<changed file>. It is best to simply do "svn diff".

3) Now for the actual content of the patch, it must be noted that
ignoring WindowsError in copy2 breaks compatibility. Not that there is
any reason for any one to be depending on it, but I just thought I would
point it out. In any case, it will require slight doc change. 

Lastly, just to be clear, the original problem reported in this bug
would still remain.
History
Date User Action Args
2007-12-04 21:10:50draghuramsetspambayes_score: 0.0185998 -> 0.0185998
recipients: + draghuram, gvanrossum, facundobatista, amaury.forgeotdarc, christian.heimes, ianare
2007-12-04 21:10:50draghuramsetspambayes_score: 0.0185998 -> 0.0185998
messageid: <1196802650.58.0.463037739964.issue1545@psf.upfronthosting.co.za>
2007-12-04 21:10:50draghuramlinkissue1545 messages
2007-12-04 21:10:49draghuramcreate