Message 57048 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	hupp
Recipients	hupp
Date	2007-11-02.12:46:27
SpamBayes Score	0.005621979
Marked as misclassified	No
Message-id	<1194007588.59.0.396140192089.issue1373@psf.upfronthosting.co.za>
In-reply-to

Content
The attached patch resolves the intermittent test_xmlrpc failures reported by Neal Norwitz[0]. test_xmlrpc starts the XMLRPC server with a socket timeout. This puts the socket into non-blocking mode which is incompatible with the use of socket.makefile as used by SocketServer. To work around this the test was specifically ignoring temporary read errors but the ignore was no longer working. The patch resolves this by removing the call to socket.settimeout and the code to ignore temporary read errors. I also had to change the `numrequests' parameter in FailingServerTestCase from 2->1. This test case only makes a single request per test (like the others) so numrequests=2 caused the test to hang. [0]http://mail.python.org/pipermail/python-3000/2007-October/011073.html

The attached patch resolves the intermittent test_xmlrpc failures
reported by Neal Norwitz[0].

test_xmlrpc starts the XMLRPC server with a socket timeout.  This puts
the socket into non-blocking mode which is incompatible with the use of
socket.makefile as used by SocketServer.  To work around this the test
was specifically ignoring temporary read errors but the ignore was no
longer working.

The patch resolves this by removing the call to socket.settimeout and
the code to ignore temporary read errors.  
 
I also had to change the `numrequests' parameter in
FailingServerTestCase from 2->1.  This test case only makes a single
request per test (like the others) so numrequests=2 caused the test to hang.

[0]http://mail.python.org/pipermail/python-3000/2007-October/011073.html

Files
File name	Uploaded
xmlrpc_nonblock.patch	hupp, 2007-11-02.12:46:27

History
Date	User	Action	Args
2007-11-02 12:46:28	hupp	set	spambayes_score: 0.00562198 -> 0.005621979 recipients: + hupp
2007-11-02 12:46:28	hupp	set	spambayes_score: 0.00562198 -> 0.00562198 messageid: <1194007588.59.0.396140192089.issue1373@psf.upfronthosting.co.za>
2007-11-02 12:46:28	hupp	link	issue1373 messages
2007-11-02 12:46:27	hupp	create