This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gvanrossum
Recipients MrJean1, christian.heimes, gvanrossum, nnorwitz
Date 2007-10-30.00:42:26
SpamBayes Score 0.01964052
Marked as misclassified No
Message-id <1193704946.42.0.939603638817.issue1329@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks!!  Code review:

Shouldn't closefd be passed as 1 in import.c?

I don't see the point of distinguishing between -1 and +1.  The block
"if (closefd < 0) { closefd = 1; }" looks rather silly.

In io.py, you should document that closefd must not be False when a
filename is given.

I think in _fileio.c, you can insist that the closefd argument is an int
(a bool will work anyway, as bool is a subclass of int).

I don't think we should warn when trying to close an unclosable fd; it
should really just be a no-op.  Also, if you are going to call
PyErr_WarnEx(), you should test its return value (it can raise an
exception!).

Please don't add trailing whitespace.
History
Date User Action Args
2007-10-30 00:42:26gvanrossumsetspambayes_score: 0.0196405 -> 0.01964052
recipients: + gvanrossum, nnorwitz, christian.heimes, MrJean1
2007-10-30 00:42:26gvanrossumsetspambayes_score: 0.0196405 -> 0.0196405
messageid: <1193704946.42.0.939603638817.issue1329@psf.upfronthosting.co.za>
2007-10-30 00:42:26gvanrossumlinkissue1329 messages
2007-10-30 00:42:26gvanrossumcreate