This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author torriem
Recipients cosoleto, ggenellina, gvanrossum, josm, torriem
Date 2007-10-16.19:11:28
SpamBayes Score 0.15923047
Marked as misclassified No
Message-id <1192561889.42.0.423078900274.issue1205@psf.upfronthosting.co.za>
In-reply-to
Content
I had a situation where I was talking to a Sharp MFD printer.  Their web
server apparently does not serve chunked data properly.  However the
patch posted here put it in an infinite loop.

Somewhere around line 525 in the python 2.4 version of httplib.py, I had
to make it look like this:

        while True:
            line = self.fp.readline()
            if line == '\r\n' or not line:
                break

I added "or not line" to the if statement.  The blank line in the
chunked http was confusing the _last_chunk thing, but even when it was
set to zero, since there was no more data, this loop to eat up crlfs was
never ending.

Is this really a proper fix?  

I'm in favor of changing urllib2 to be less strict because, despite the
RFCs, we're stuck talking to all kinds of web servers (embedded ones in
particular) that simply can't easily be changed.
History
Date User Action Args
2007-10-16 19:11:29torriemsetspambayes_score: 0.15923 -> 0.15923047
recipients: + torriem, gvanrossum, ggenellina, josm, cosoleto
2007-10-16 19:11:29torriemsetspambayes_score: 0.15923 -> 0.15923
messageid: <1192561889.42.0.423078900274.issue1205@psf.upfronthosting.co.za>
2007-10-16 19:11:29torriemlinkissue1205 messages
2007-10-16 19:11:28torriemcreate