➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author christian.heimes
Recipients alexandre.vassalotti, christian.heimes, gvanrossum
Date 2007-10-15.00:57:19
SpamBayes Score 0.016931891
Marked as misclassified No
Message-id <4712BAE7.1040900@cheimes.de>
In-reply-to <ca471dc20710141713p5edce264o66f83965b31cb824@mail.gmail.com>
Content 
I found two minor bugs in the fix. In Modules/posixmodule.c the tmpnam()
and tempnam() methods return a PyString instance. Please change line
5373 and 5431 to use PyUnicode_DecodeFSDefault().

Index: Modules/posixmodule.c
===================================================================
--- Modules/posixmodule.c       (Revision 58461)
+++ Modules/posixmodule.c       (Arbeitskopie)
@@ -5370,7 +5370,7 @@
 #endif
     if (name == NULL)
         return PyErr_NoMemory();
-    result = PyString_FromString(name);
+    result = PyUnicode_DecodeFSDefault(name);
     free(name);
     return result;
 }
@@ -5428,7 +5428,7 @@
        Py_XDECREF(err);
        return NULL;
     }
-    return PyString_FromString(buffer);
+    return PyUnicode_DecodeFSDefault(buffer);
 }
 #endif
History
Date User Action Args
2007-10-15 00:57:19christian.heimessetspambayes_score: 0.0169319 -> 0.016931891
recipients: + christian.heimes, gvanrossum, alexandre.vassalotti
2007-10-15 00:57:19christian.heimeslinkissue1272 messages
2007-10-15 00:57:19christian.heimescreate