Message52985
Adam,
I've spent some time looking at this patch. Bear in mind this is my first foray into Py3k. Still, I'm confused about what's going on here. I'm hoping you can help me understand the changes. In parse_save_field, you replaced PyString_FromStringAndSize with PyUnicode_FromUnicode, however in get_nullchar_as_None you replaced it with PyUnicode_DecodeASCII.
When I execute the csv tests there are a number of assertion errors related to the default delimiter. The traceback goes something like this:
FAIL: test_writer_kw_attrs (__main__.Test_Csv)
----------------------------------------------------------------------
Traceback (most recent call last):
File "Lib/test/test_csv.py", line 88, in test_writer_kw_attrs
self._test_kw_attrs(csv.writer, StringIO())
File "Lib/test/test_csv.py", line 75, in _test_kw_attrs
self.assertEqual(obj.dialect.delimiter, ':')
AssertionError: s'\x00' != ':'
Any idea how to solve that? It looks to me like some Unicode buffer might be getting interpreted as a char *, but I'm not sure.
Skip
|
|
Date |
User |
Action |
Args |
2007-08-23 15:59:33 | admin | link | issue1767398 messages |
2007-08-23 15:59:33 | admin | create | |
|