Message49705
Logged In: YES
user_id=580910
* The import of zipfile itself is a bug
* The limit should indead be raised to (1<<31-1).
* the diskno and nodisks assertions are present in the current version of
zipfiles, but I agree that those should be changed into exceptions.
* I've updated main to document and actually allow the -t option
* TestZip64InSmallFiles restores the ZIP64_LIMIT in the tearDown method,
isn't that good enough?
I sure hope that nobody actually uses the file_offset. The only usecase I can
think of for that is to reimplement the read method. If it turns out that this
change does break existing code we could add yet another option, but lets
wait with that until someone actually complains.
I've uploaded a new version of the patch that fixes all these issues.
BTW. Thanks for the review. |
|
Date |
User |
Action |
Args |
2007-08-23 15:46:47 | admin | link | issue1446489 messages |
2007-08-23 15:46:47 | admin | create | |
|