Message400225
I'd like to propose further enhancements:
- use intermingled declarations in the affected functions; this will make GIL acquisition stand more out, and it also improves readability and makes it easier to trace refs
- take the naming step further: I'd like to normalise PyObject * callback variable names, the extremely long function_pinboard_* names, and also drop the C callback prefixes ('_' and 'pysqlite_')
If you agree, I'll create separate PR's for those; one for each refactor. I think it will enhance readability a lot. |
|
Date |
User |
Action |
Args |
2021-08-24 18:31:48 | erlendaasland | set | recipients:
+ erlendaasland, petr.viktorin |
2021-08-24 18:31:48 | erlendaasland | set | messageid: <1629829908.43.0.809940237436.issue44991@roundup.psfhosted.org> |
2021-08-24 18:31:48 | erlendaasland | link | issue44991 messages |
2021-08-24 18:31:48 | erlendaasland | create | |
|