Message39344
Logged In: YES
user_id=33168
I reviewed the patch. I don't like the usage of enc (and
str to a lesser extent). In particular, there is an
encoding field which is generally used. enc is used as a
temporary from the callback. I don't have a solution, so
perhaps it would be best to doc the purpose, usage and
interaction of enc & str.
There are some differences between the standard formatting
and that used in the patch. return on same line as if
among others. But these aren't too bad. Although I don't
love the line do t++; while (...);.
I didn't see any problems with the patch. |
|
Date |
User |
Action |
Args |
2007-08-23 15:11:47 | admin | link | issue534304 messages |
2007-08-23 15:11:47 | admin | create | |
|