This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author steve.dower
Recipients eryksun, paul.moore, steve.dower, tim.golden, zach.ware
Date 2019-02-02.21:07:58
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1549141678.96.0.166095424472.issue29734@roundup.psfhosted.org>
In-reply-to
Content
We certainly shouldn't be calling CloseHandle on a parameter like this anyway, so the change looks good to me.

However, I notice that we don't necessarily preserve GetLastError() throughout here, so perhaps we ought to consider changing the return value interpretation at some point? (e.g. CloseHandle() may change it, and so we lose the actual error) That can be a future task though.
History
Date User Action Args
2019-02-02 21:08:00steve.dowersetrecipients: + steve.dower, paul.moore, tim.golden, zach.ware, eryksun
2019-02-02 21:07:58steve.dowersetmessageid: <1549141678.96.0.166095424472.issue29734@roundup.psfhosted.org>
2019-02-02 21:07:58steve.dowerlinkissue29734 messages
2019-02-02 21:07:58steve.dowercreate