➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eelizondo
Recipients benjamin.peterson, eelizondo, ronaldoussoren, twouters
Date 2018-08-28.19:59:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1535486352.44.0.56676864532.issue34522@psf.upfronthosting.co.za>
In-reply-to
Content 
@ronaldoussoren Please read the complete analysis from the mailing list: https://mail.python.org/pipermail/python-dev/2018-August/154946.html. The description here was just a rehash and I probably missed some context. 

Particularly, when I said: "PyTypeObject's ob_type should always be set by PyType_Ready" I was referring to the PyTypeObject's that are statically set in C code. Metatypes explicitly have to set the ob_type and that's already handled.

In the current state of things, you have static PyTypeObjects that are being used before calling PyType_Ready due to this macro. This change just standardizes the header of static PyTypeObject throughout the entire codebase.
History
Date User Action Args
2018-08-28 19:59:12eelizondosetrecipients: + eelizondo, twouters, ronaldoussoren, benjamin.peterson
2018-08-28 19:59:12eelizondosetmessageid: <1535486352.44.0.56676864532.issue34522@psf.upfronthosting.co.za>
2018-08-28 19:59:12eelizondolinkissue34522 messages
2018-08-28 19:59:12eelizondocreate