This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author skrah
Recipients serhiy.storchaka, skrah, vstinner
Date 2017-08-25.12:21:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1503663675.69.0.755105710638.issue31275@psf.upfronthosting.co.za>
In-reply-to
Content
The last fall-through warning is in _codecs_iso2022.c. IMO the
current code is equivalent to this, but I'm no codecs expert at
all:


diff --git a/Modules/cjkcodecs/_codecs_iso2022.c b/Modules/cjkcodecs/_codecs_iso2022.c
index 1ce4218f30..abf214880f 100644
--- a/Modules/cjkcodecs/_codecs_iso2022.c
+++ b/Modules/cjkcodecs/_codecs_iso2022.c
@@ -807,15 +807,9 @@ jisx0213_encoder(const Py_UCS4 *data, Py_ssize_t *length, void *config)
     case 2: /* second character of unicode pair */
         coded = find_pairencmap((ucs2_t)data[0], (ucs2_t)data[1],
                                 jisx0213_pair_encmap, JISX0213_ENCPAIRS);
-        if (coded == DBCINV) {
-            *length = 1;
-            coded = find_pairencmap((ucs2_t)data[0], 0,
-                      jisx0213_pair_encmap, JISX0213_ENCPAIRS);
-            if (coded == DBCINV)
-                return MAP_UNMAPPABLE;
-        }
-        else
+        if (coded != DBCINV) {
             return coded;
+        /* fall through */
 
     case -1: /* flush unterminated */
         *length = 1;
History
Date User Action Args
2017-08-25 12:21:15skrahsetrecipients: + skrah, vstinner, serhiy.storchaka
2017-08-25 12:21:15skrahsetmessageid: <1503663675.69.0.755105710638.issue31275@psf.upfronthosting.co.za>
2017-08-25 12:21:15skrahlinkissue31275 messages
2017-08-25 12:21:15skrahcreate