Message300454
In all of these cases PyArg_ParseTupleAndKeywords() is used in uncommon way. These functions accept variable number of positional-only arguments, and PyArg_ParseTupleAndKeywords() is called with empty args tuple for parsing keyword arguments only. The patch uses a trick for detecting this case and generating more appropriate error message. Correct error message is generated in a normal case too.
LGTM. But it may be worth to add a short comment about the necessary of this special case. And please add tests for error messages in all of these functions. test_call looks appropriate place for them. |
|
Date |
User |
Action |
Args |
2017-08-17 18:30:23 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, vstinner, Oren Milman |
2017-08-17 18:30:22 | serhiy.storchaka | set | messageid: <1502994622.99.0.676560178017.issue31229@psf.upfronthosting.co.za> |
2017-08-17 18:30:22 | serhiy.storchaka | link | issue31229 messages |
2017-08-17 18:30:22 | serhiy.storchaka | create | |
|