Message288723
I actually looked at the patch and have a few comments:
1. You need to put Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS before the sqlite3 calls (especially the sleep).
2. I think that the `pysqlite_connection_backup` function will look a lot better if you will have a cleanup/error label.
I am not a core developer but I think you should open the PR as it will be easier for the CR. |
|
Date |
User |
Action |
Args |
2017-02-28 19:57:30 | palaviv | set | recipients:
+ palaviv, ghaering, ced, r.david.murray, berker.peksag, lelit, abarry |
2017-02-28 19:57:30 | palaviv | set | messageid: <1488311850.87.0.807461558797.issue27645@psf.upfronthosting.co.za> |
2017-02-28 19:57:30 | palaviv | link | issue27645 messages |
2017-02-28 19:57:30 | palaviv | create | |
|