Message288567
Testing with Django seems indicated an issue. I did the following with 3.6 patch (cherry-pick to bea9d2f64) on macOS with OpenSSL installed via Homebrew:
$ cd /Users/andrei/Python/cpython/
$ export CFLAGS="-I/usr/local/opt/openssl/include"
$ export LDFLAGS="-L/usr/local/opt/openssl/lib"
$ ./configure --with-pydebug --prefix=/Users/andrei/Python/installed/
$ make -j
$ make install
Then in Django (master, b427f0d674):
$ cd /Users/andrei/Python/django/
$ ../../installed/bin/pip3.6 install -r ./requirements/py3.txt
$ PYTHONPATH=.. DJANGO_SETTINGS_MODULE=test_sqlite ../../installed/bin/python3.6 ./runtests.py
That produced one error:
======================================================================
ERROR: auth_tests.test_hashers (unittest.loader._FailedTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/andrei/Python/installed/lib/python3.6/unittest/case.py", line 59, in testPartExecutor
yield
File "/Users/andrei/Python/installed/lib/python3.6/unittest/case.py", line 601, in run
testMethod()
File "/Users/andrei/Python/installed/lib/python3.6/unittest/loader.py", line 34, in testFailure
raise self._exception
ImportError: Failed to import test module: auth_tests.test_hashers
Traceback (most recent call last):
File "/Users/andrei/Python/installed/lib/python3.6/unittest/loader.py", line 426, in _find_test_path
module = self._get_module_from_name(name)
File "/Users/andrei/Python/installed/lib/python3.6/unittest/loader.py", line 367, in _get_module_from_name
__import__(name)
File "/Users/andrei/Python/django/tests/auth_tests/test_hashers.py", line 20, in <module>
if crypt.crypt('', '') is None:
File "/Users/andrei/Python/installed/lib/python3.6/crypt.py", line 47, in crypt
return _crypt.crypt(word, salt)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfb in position 1: invalid start byte
Ran 11695 tests in 259.390s
FAILED (errors=1, skipped=1149, expected failures=4)
Then I ran the same tests in 3.6.0 virtualenv installed via pyenv:
$ pyenv virtualenv 3.6.0 djtest
$ pyenv shell djtest
$ pip install -r ./requirements/py3.txt
$ PYTHONPATH=.. DJANGO_SETTINGS_MODULE=test_sqlite python ./runtests.py
and they went fine:
Ran 11723 tests in 87.369s
OK (skipped=1149, expected failures=4)
So the patch causes 1 error and misses 28 tests. I'll try to figure out the problem with failing test and what tests are missing. |
|
Date |
User |
Action |
Args |
2017-02-25 15:00:45 | Andrei Fokau | set | recipients:
+ Andrei Fokau, barry, rbcollins, ezio.melotti, michael.foord |
2017-02-25 15:00:45 | Andrei Fokau | set | messageid: <1488034845.03.0.98029872485.issue29642@psf.upfronthosting.co.za> |
2017-02-25 15:00:45 | Andrei Fokau | link | issue29642 messages |
2017-02-25 15:00:43 | Andrei Fokau | create | |
|