Message287255
PyDict_SetItem() can trigger destructor which first call _PyObjectDict_SetItem() which change CACHED_KEYS(tp) and then call PyDict_SetItem() which call dictresize(). At the end it may be possible that cached != ((PyDictObject *)dict)->ma_keys and cached != CACHED_KEYS(tp) and CACHED_KEYS(tp) != ((PyDictObject *)dict)->ma_keys.
Wouldn't be better to just update the cached variable after calling PyDict_SetItem()?
if (was_shared && (cached = CACHED_KEYS(tp)) != NULL && cached != ((PyDictObject *)dict)->ma_keys) |
|
Date |
User |
Action |
Args |
2017-02-07 20:00:51 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, vstinner, methane, xiang.zhang, audric |
2017-02-07 20:00:51 | serhiy.storchaka | set | messageid: <1486497651.65.0.250704881719.issue29438@psf.upfronthosting.co.za> |
2017-02-07 20:00:51 | serhiy.storchaka | link | issue29438 messages |
2017-02-07 20:00:51 | serhiy.storchaka | create | |
|