Message286423
Iām not really an expert on non-ASCII URLs / IRIs. Maybe it is obvious to other people that this is a good general implementation, but for me to thoroughly review it I would need time to research the relevant RFCs, other implementations, suitability for the URL schemes listed at <https://docs.python.org/dev/library/urllib.parse.html>, security implications, etc.
One problem problem with using urlunsplit() is it would strip empty URL components, e.g. quote_iri("http://example/file#") -> "http://example/file". See Issue 22852. This is highlighted by the file:///[. . .] ā file:/[. . .] test case.
FYI Martin Panter and vadmium are both just me, no need to get too excited. :) I just updated my settings for Rietveld (code review), so hopefully that is more obvious now. |
|
Date |
User |
Action |
Args |
2017-01-29 01:06:54 | martin.panter | set | recipients:
+ martin.panter, janssen, orsenthil, vstinner, ajaksu2, ezio.melotti, a.badger, thezulk, Graham.Oliver |
2017-01-29 01:06:54 | martin.panter | set | messageid: <1485652014.02.0.729738315483.issue3991@psf.upfronthosting.co.za> |
2017-01-29 01:06:54 | martin.panter | link | issue3991 messages |
2017-01-29 01:06:53 | martin.panter | create | |
|