Message286337
> but an isinstance test seems pretty redundant.
Tests are never redundant :-) Just add one-two asserts that you think should be true about issubclass and isinstance with these types (like self.assertIsInstance(''.__add__, types.MethodWrapperType)). String representation on the contrary is less important.
For some reason your patch is still not recognized by review tool. But don't worry about this, if it will not work, I will try to fix it. |
|
Date |
User |
Action |
Args |
2017-01-26 23:06:13 | levkivskyi | set | recipients:
+ levkivskyi, gvanrossum, Wheerd |
2017-01-26 23:06:13 | levkivskyi | set | messageid: <1485471973.77.0.280282766673.issue29377@psf.upfronthosting.co.za> |
2017-01-26 23:06:13 | levkivskyi | link | issue29377 messages |
2017-01-26 23:06:13 | levkivskyi | create | |
|