This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients asvetlov, barry, belopolsky, berker.peksag, bkabrda, cimarron, docs@python, jcea, martin.panter, md5i, python-dev, sandro.tosi, serhiy.storchaka
Date 2017-01-10.08:48:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1484038120.3.0.225079902091.issue15657@psf.upfronthosting.co.za>
In-reply-to
Content
.
The documentation did not get merged properly into 3.6+. And even in 3.5, under METH_KEYWORDS, I propose to change “The flag is typically combined with METH_VARARGS” to “The flag must be combined . . .”.

The remaining issue15657_36.diff patch looks out of date. There is a _PyCFunction_FastCallDict() function that appears to also need adjusting.

But instead of changing the value of METH_KEYWORDS, wouldn’t it be safer to just accept METH_KEYWORDS (= 2) on its own as a valid value? This is what Python 2 does. Essentially, revert the first hunk of

https://hg.python.org/cpython/diff/b7bfa780a882/Objects/methodobject.c

but without METH_OLDARGS, whose value was zero anyway.

BTW, the statement did not need to be removed in Python 2, but IMO it’s fine now without the statment. The statement was added in revision 1564c6839e6b.
History
Date User Action Args
2017-01-10 08:48:40martin.pantersetrecipients: + martin.panter, barry, jcea, belopolsky, md5i, asvetlov, sandro.tosi, docs@python, python-dev, berker.peksag, serhiy.storchaka, bkabrda, cimarron
2017-01-10 08:48:40martin.pantersetmessageid: <1484038120.3.0.225079902091.issue15657@psf.upfronthosting.co.za>
2017-01-10 08:48:40martin.panterlinkissue15657 messages
2017-01-10 08:48:40martin.pantercreate