This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author wgianopoulos
Recipients wgianopoulos
Date 2017-01-02.20:37:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483389479.69.0.4543924586.issue29135@psf.upfronthosting.co.za>
In-reply-to
Content
So, the arguments to run_process are not escaped when logged such that the logged command is un-parsable.
The following call:

self.run_process(['notify-send', '--app-name', 'Mozilla Build System', 'Mozilla Build System', msg])  where msg='Build complete'

ends up logging the following:

/usr/bin/notify-send --app-name Mozilla Build System Mozilla Build System Build complete

Where to be a valid command it needs to be:

/usr/bin/notify-send --app-name 'Mozilla Build System' 'Mozilla Build System' 'Build complete'


So, I think this needs to either not log the command at all or for each parameter replace any occurrence of the character "'" with "\'" and then enclose the entire parameter with "'" to make sure the logged command can actually be properly parsed.
History
Date User Action Args
2017-01-02 20:37:59wgianopoulossetrecipients: + wgianopoulos
2017-01-02 20:37:59wgianopoulossetmessageid: <1483389479.69.0.4543924586.issue29135@psf.upfronthosting.co.za>
2017-01-02 20:37:59wgianopouloslinkissue29135 messages
2017-01-02 20:37:59wgianopouloscreate