Message284498
So, the arguments to run_process are not escaped when logged such that the logged command is un-parsable.
The following call:
self.run_process(['notify-send', '--app-name', 'Mozilla Build System', 'Mozilla Build System', msg]) where msg='Build complete'
ends up logging the following:
/usr/bin/notify-send --app-name Mozilla Build System Mozilla Build System Build complete
Where to be a valid command it needs to be:
/usr/bin/notify-send --app-name 'Mozilla Build System' 'Mozilla Build System' 'Build complete'
So, I think this needs to either not log the command at all or for each parameter replace any occurrence of the character "'" with "\'" and then enclose the entire parameter with "'" to make sure the logged command can actually be properly parsed. |
|
Date |
User |
Action |
Args |
2017-01-02 20:37:59 | wgianopoulos | set | recipients:
+ wgianopoulos |
2017-01-02 20:37:59 | wgianopoulos | set | messageid: <1483389479.69.0.4543924586.issue29135@psf.upfronthosting.co.za> |
2017-01-02 20:37:59 | wgianopoulos | link | issue29135 messages |
2017-01-02 20:37:59 | wgianopoulos | create | |
|