Author Jim Fasarakis-Hilliard
Recipients Jim Fasarakis-Hilliard, ned.deily, serhiy.storchaka
Date 2016-12-30.21:53:37
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1483134817.73.0.63128157666.issue29116@psf.upfronthosting.co.za>
In-reply-to
Content
Should that message be the one predominantly used for sequences, i.e:

   TypeError: can only concatenate class1 (not "class2") to class1

or should another one be used like "Unsupported operand type(s) for op: 'class1' and 'class2'?

The first is problematic with cases like `+=` where an iterable is accepted, the second seems better to me at least.

As for `operator.concat`, any reason why the check is made beforehand to see if the first argument has a `__getitem__` method? Couldn't that just be removed allowing the exception from `concat(1, '')` to just propagate to the caller?
History
Date User Action Args
2016-12-30 21:53:37Jim Fasarakis-Hilliardsetrecipients: + Jim Fasarakis-Hilliard, ned.deily, serhiy.storchaka
2016-12-30 21:53:37Jim Fasarakis-Hilliardsetmessageid: <1483134817.73.0.63128157666.issue29116@psf.upfronthosting.co.za>
2016-12-30 21:53:37Jim Fasarakis-Hilliardlinkissue29116 messages
2016-12-30 21:53:37Jim Fasarakis-Hilliardcreate