Message284292
There a problem with PySlice_GetIndicesEx() (see issue27867). Buffer length shouldn't be evaluated before PySlice_GetIndicesEx() since it can call user code that can change buffer length. This issue can't be solved without first solving issue27867.
get_buf() is called twice. First for getting the size, and later in buffer_item() or after PySlice_GetIndicesEx() for getting a pointer. I think it can be called once.
Ammar, please write a unittest for this issue. It should also cover bugs in the first two versions of the patch. |
|
Date |
User |
Action |
Args |
2016-12-29 20:07:21 | serhiy.storchaka | set | recipients:
+ serhiy.storchaka, benjamin.peterson, methane, ammar2, dyjakan |
2016-12-29 20:07:21 | serhiy.storchaka | set | messageid: <1483042041.58.0.148221475124.issue29028@psf.upfronthosting.co.za> |
2016-12-29 20:07:21 | serhiy.storchaka | link | issue29028 messages |
2016-12-29 20:07:21 | serhiy.storchaka | create | |
|