➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author yselivanov
Recipients Eric Appelt, gvanrossum, ncoghlan, ned.deily, yselivanov
Date 2016-12-14.01:05:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1481677532.01.0.818815777257.issue28091@psf.upfronthosting.co.za>
In-reply-to
Content 
> I believe that I addressed all the comments in the previous review (although its always possible I missed something), and have a new patch with the improvements and fixes.

Thanks Eric!  I've left a few more comments in the review.  Almost there!

> I also noticed that in asyncio, loop.shutdown_asyncgens() is a coroutinemethod and fixed the markup to reflect that as I previously labeled it a method. The example I added here is as suggested, but it differs from the example in PEP525 in that shutdown_asyncgens() is run in a finally clause, which makes sense to me.

Right, I'll fix the PEP. Thanks!
History
Date User Action Args
2016-12-14 01:05:32yselivanovsetrecipients: + yselivanov, gvanrossum, ncoghlan, ned.deily, Eric Appelt
2016-12-14 01:05:32yselivanovsetmessageid: <1481677532.01.0.818815777257.issue28091@psf.upfronthosting.co.za>
2016-12-14 01:05:31yselivanovlinkissue28091 messages
2016-12-14 01:05:31yselivanovcreate