This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Eric Appelt
Recipients Eric Appelt, gvanrossum, ncoghlan, ned.deily, yselivanov
Date 2016-12-13.04:24:40
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1481603084.45.0.987191520388.issue28091@psf.upfronthosting.co.za>
In-reply-to
Content
I believe that I addressed all the comments in the previous review (although its always possible I missed something), and have a new patch with the improvements and fixes.

I also noticed that in asyncio, loop.shutdown_asyncgens() is a coroutinemethod and fixed the markup to reflect that as I previously labeled it a method. The example I added here is as suggested, but it differs from the example in PEP525 in that shutdown_asyncgens() is run in a finally clause, which makes sense to me.

When applying the comments to sys.set_asyncgen_hooks() I verified that the keywords are optional but it is apparently not keyword only. I couldn't find many good examples of referencing source, so you may want to closely check how I linked to the shutdown_asyncgens() implementation.
History
Date User Action Args
2016-12-13 04:24:45Eric Appeltsetrecipients: + Eric Appelt, gvanrossum, ncoghlan, ned.deily, yselivanov
2016-12-13 04:24:44Eric Appeltsetmessageid: <1481603084.45.0.987191520388.issue28091@psf.upfronthosting.co.za>
2016-12-13 04:24:44Eric Appeltlinkissue28091 messages
2016-12-13 04:24:44Eric Appeltcreate