This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rhettinger
Recipients python-dev, rhettinger, serhiy.storchaka
Date 2016-11-12.07:27:45
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1478935666.24.0.713154119968.issue28665@psf.upfronthosting.co.za>
In-reply-to
Content
No thanks. These aren't really important opcodes.  While there may be a modest speed improvement for the same reasons as the previous patch (avoiding unnecessary work), the main reason to do these two patches is because you had suggested it and because it makes the code follow the same patterns used elsewhere. In general, the short opcodes consistently try to use the macro form of calls where ever it is possible or convenient.  Also, to my eyes, the patched code looks cleaner because it is easier to see the refcount effects.

That said, I don't care about these two very much, so if you want the improvement and think it is correct, please say so; otherwise, close this and we can leave the code inconsistent in its approach and having it do work that is known to be unnecessary.
History
Date User Action Args
2016-11-12 08:32:10rhettingerunlinkissue28665 messages
2016-11-12 07:27:46rhettingersetrecipients: + rhettinger, python-dev, serhiy.storchaka
2016-11-12 07:27:46rhettingersetmessageid: <1478935666.24.0.713154119968.issue28665@psf.upfronthosting.co.za>
2016-11-12 07:27:46rhettingerlinkissue28665 messages
2016-11-12 07:27:45rhettingercreate