This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author yselivanov
Recipients gvanrossum, methane, socketpair, yselivanov
Date 2016-10-21.21:00:01
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1477083601.66.0.306993611361.issue28430@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks good.  2 things:

- It appears it also touches Misc/NEWS a bit too much. Please make sure to not to commit that.

- I'd also add a comment explaining why we ignore values passed to FI.send() and simply send None.  The reason is how Future.__iter__ is designed:

   class Future:
      def __iter__(self):
        if not self.done():
            self._asyncio_future_blocking = True
            yield self  # This tells Task to wait for completion.
        assert self.done(), "yield from wasn't used with future"
        return self.result()  # May raise too.

^-- Future.__iter__ doesn't care about values that are pushed to the generator, it just returns "self.result()".
History
Date User Action Args
2016-10-21 21:00:01yselivanovsetrecipients: + yselivanov, gvanrossum, methane, socketpair
2016-10-21 21:00:01yselivanovsetmessageid: <1477083601.66.0.306993611361.issue28430@psf.upfronthosting.co.za>
2016-10-21 21:00:01yselivanovlinkissue28430 messages
2016-10-21 21:00:01yselivanovcreate