Message277105
josh.r:
> I believe per PEP7, we're still sticking to ANSI C (aka C89), and specifically, "all declarations must be at the top of a block (not necessarily at the top of function".
Python 3.6 branch allows some C99 features.
https://www.python.org/dev/peps/pep-0007/#c-dialect
> Removing those unrelated changes looks like it would dramatically reduce the churn too, making review easier.
While I think refactoring around changes is practical [1], I agree that I made too much change. I'll reduce diff size.
[1] Changing without refactoring is hard sometimes. Whole file refactoring
without actual change may cause many conflicts against other patches. |
|
Date |
User |
Action |
Args |
2016-09-21 07:31:02 | methane | set | recipients:
+ methane, tim.peters, rhettinger, serhiy.storchaka, josh.r |
2016-09-21 07:31:01 | methane | set | messageid: <1474443062.0.0.0843970865392.issue28201@psf.upfronthosting.co.za> |
2016-09-21 07:31:01 | methane | link | issue28201 messages |
2016-09-21 07:31:01 | methane | create | |
|