Message271855
@Ethan
I reviewed your latest patch. I think it's a good step forward in terms of simplicity. Most of my comments were not major.
Even before this patch, I was mulling around how enum.Unique, enum.UniqueEnum, and enum.unique seemed to violate the "There should be one obvious way to do it" principle, so I like that you omitted those in the latest patch.
Looks good to me, thanks for all of your work! |
|
Date |
User |
Action |
Args |
2016-08-02 21:31:29 | John Hagen | set | recipients:
+ John Hagen, barry, eli.bendersky, ethan.furman |
2016-08-02 21:31:29 | John Hagen | set | messageid: <1470173489.5.0.0761801420703.issue26988@psf.upfronthosting.co.za> |
2016-08-02 21:31:29 | John Hagen | link | issue26988 messages |
2016-08-02 21:31:29 | John Hagen | create | |
|